Migrate existing patch series to patchable#1005
Merged
Conversation
Contributor
Author
|
All products have now been converted except for NiFi, since #1006 partially tackles that. Will normalize NiFi after that PR is merged. |
Contributor
Author
|
Converted/normalized NiFi as well, now that #1006 is in. |
dervoeti
reviewed
Feb 27, 2025
Member
dervoeti
left a comment
dervoeti
left a comment
There was a problem hiding this comment.
Looks good, a few remarks:
- This patch file contains "Subject" in the subject and the filename.
- Patches for non-product components are not migrated yet: Phoenix, hbase-operator-tools and hbase-connectors. Also, maybe we need to align the folder structure for these components at some point. But I'd say the restructuring does not need be part of this PR, it can be done when implementing the solution for https://github.com/stackabletech/decisions/issues/44. If it makes things easier we could also do it in this PR, not sure what's the best solution though.
- We'll need to remove Druid 26 and migrate the patches for 30.0.1 and 31.0.1 after this is merged (should happen soon, is waiting for review). Can also happen in a follow up PR or in the PR for Druid.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1004
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.